Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/123 refactor sorting of report code column #331

Merged
merged 23 commits into from
Jun 10, 2022
Merged

Feature/123 refactor sorting of report code column #331

merged 23 commits into from
Jun 10, 2022

Conversation

Elaine-Krauss-TCG
Copy link
Contributor

Implements the front-end elements of API ticket 123

Paired with API feature/123

Elaine Krauss and others added 22 commits May 26, 2022 09:19
Sorts on "report_code__label" instead of "report_code_label" now
b340543
WIP
a485a53
WIP, getting NGRX to work...
ef0c0e2
WIP
be73b6b
More WIP
e230e30
It now seems to actually run?
702c48f
reportCodeLabelList now actually appears in the NGRX store!
fab8e16
Properly dispatches the updateLabelLookupAction to the store
99c55de
Refactors the Report List to utilize the Report Code Label endpoint o…
b05c448 
…n the server instead of a hardcoded list
Integrates feedback from CloudSonar
51de4fe
Adds new tests for the findOnReportCode pipe, and corrects a potentia…
7066805 
…l bug in the pipe itself
Fixes a typo
68eec13
Removes a console.log() call
b50fabc
Removes unused services
c1de30f
Removed an unused property
662e751
Removes a console.log() call
20ecb35
Removes console.log() call
5dcc838
Removes console.log() call
9752fd0
Merge branch 'develop' of https://github.com/fecgov/fecfile-web-app i…
8d8eccc 
…nto develop
Merged report-list.component.ts
8dc28d1
Removes an unused import
324fc1b
Implements feedback from CircleCI linting test
75a0958
@Elaine-Krauss-TCG Elaine-Krauss-TCG mentioned this pull request Jun 10, 2022
Merged
@Elaine-Krauss-TCG Elaine-Krauss-TCG mentioned this pull request Jun 10, 2022
Closed
toddlees
toddlees requested changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@toddlees toddlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just reduce the verbosity of the conditionals in the label pipe

front-end/src/app/shared/pipes/report-code-label-list.pipe.ts Outdated Show resolved Hide resolved
front-end/src/app/shared/pipes/report-code-label-list.pipe.ts Outdated Show resolved Hide resolved
front-end/src/app/shared/pipes/report-code-label-list.pipe.ts Show resolved Hide resolved
Refactors the FindOnReportCode pipe to implement feedback from code r…
458da09 
…eview as well as the associated unit tests
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@toddlees toddlees merged commit e9f5736 into develop Jun 10, 2022
@toddlees toddlees mentioned this pull request Jun 17, 2022
Merged
@Elaine-Krauss-TCG Elaine-Krauss-TCG deleted the feature/123-Refactor-Sorting-of_Report-Code-Column branch July 20, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddlees toddlees toddlees approved these changes

@mjtravers mjtravers Awaiting requested review from mjtravers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elaine-Krauss-TCG @toddlees